Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Google+ APIs because it will be shutdown #319

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

saputradharma
Copy link

@saputradharma saputradharma commented Dec 21, 2018

Fix Google+ APIs being shutdown #317, actually just take changes from here #283

@saputradharma saputradharma changed the title [UPDATE] Change google plus api Change Google+ APIs because its being shutdown Dec 21, 2018
@saputradharma saputradharma changed the title Change Google+ APIs because its being shutdown Change Google+ APIs because it will be shutdown Dec 21, 2018
@taylorotwell taylorotwell merged commit 79316f3 into laravel:3.0 Dec 21, 2018
@arborrow
Copy link

arborrow commented Jan 1, 2019

Quick question, I have a Laravel 5.6 site using socialite. When I run a composer update I am getting v3.2.0 which does not have the updates from this pull request I'm curious about the best way for me to be prepared for the Google+ API being shutdown. Is the plan to merge these changes into a new tag, such as v3.3.0 so that I can simply do a composer update and expect things to work or should I update composer json to specifically make use of the 3.0 branch. Looking at v3.2.0...3.0 it seems that there are other changes that have not been pulled into latest tagged version and thus excluded from being implemented on my site (if I am understanding the proper flow of things).

@driesvints
Copy link
Member

@arborrow you can require 3.0.x-dev https://packagist.org/packages/laravel/socialite#3.0.x-dev

@arborrow
Copy link

arborrow commented Jan 4, 2019

@driesvints thanks, specifying 3.0.x-dev in composer.json worked perfectly. Just for the sake of documentation, I was checking the user's domain using the Google+ API user['domain']; however, the People API uses user['hd']. Once I cleaned up my references to domain to hd in my code everything else seemed to work just fine and I was able to disable the Google+ API.

@rajjanorkar
Copy link

@taylorotwell - please release this change google+ api change as next minor version so we can pull it through composer.

Anyways google+ api is shutting down, so its not gonna work.

@driesvints
Copy link
Member

@rajjanorkar please read my comment here: #319 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants